Fix incorrect key name so registerManualConfirm works#14455
Merged
lunny merged 1 commit intogo-gitea:masterfrom Jan 26, 2021
Merged
Fix incorrect key name so registerManualConfirm works#14455lunny merged 1 commit intogo-gitea:masterfrom
lunny merged 1 commit intogo-gitea:masterfrom
Conversation
lunny
approved these changes
Jan 25, 2021
GiteaBot
added
the
lgtm/need 1
techknowlogick
approved these changes
Jan 25, 2021
GiteaBot
added
lgtm/done
a1012112796
added a commit
to a1012112796/gitea
that referenced
this pull request
Jan 27, 2021
* master: [skip ci] Updated translations via Crowdin Fix bug because of duplicated join (go-gitea#14454) Cron job to cleanup hook_task table (go-gitea#13080) Fix panic 500 page rendering (go-gitea#14474) [skip ci] Updated translations via Crowdin Move macaron to chi (go-gitea#14293) [skip ci] Updated translations via Crowdin Fix incorrect key name so registerManualConfirm setting works as expected. (go-gitea#14455)
a1012112796
added a commit
to a1012112796/gitea
that referenced
this pull request
Jan 27, 2021
* master: [skip ci] Updated translations via Crowdin Fix bug because of duplicated join (go-gitea#14454) Cron job to cleanup hook_task table (go-gitea#13080) Fix panic 500 page rendering (go-gitea#14474) [skip ci] Updated translations via Crowdin Move macaron to chi (go-gitea#14293) [skip ci] Updated translations via Crowdin Fix incorrect key name so registerManualConfirm setting works as expected. (go-gitea#14455)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix incorrect key name so registerManualConfirm works.
Otherwise, the registerManualConfirm setting is never enabled in the code.
The current code seems to have an obvious typo in the key name.